-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Pod default network in Annotations #174
Specify Pod default network in Annotations #174
Conversation
Pull Request Test Coverage Report for Build 524
💛 - Coveralls |
@rkamudhan @dougbtv Request you to merge this PR as early as possible. This PR would solve our use case. FOllowing is our Use case. |
Signed-off-by: Peng Liu <pliu@redhat.com>
bcb767d
to
7e7d282
Compare
@s1061123 @rkamudhan @dougbtv could you please review it? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change "multus-cni.io/default-network" to "multus-cni.io/v1/default-network"?
Once it fixed we merge it! Thank you for your cooperation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with moving forward on this one, there's no rush and it shouldn't block the merge, but... Let's follow up with some documentation -- one that includes a big warning for usage. We can also understate it in the documentation -- as to not encourage people to use this functionality for non-standard use-cases. I created the issue in #200. Again, no big priority on the documentation, but, should be a follow up at some point. Thanks!
We've been keeping up with this PR and have been testing the changes as they've come through. The recommendation of using Below is the error encountered when attempting to use the recommended annotation name:
|
@dougbtv, thanks for reminding. I'll prepare the document in another patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for your work!
Signed-off-by: Greg Bock <greg.bock@stackpath.com> Co-Authored-By: Joshua Reese <joshua.reese@stackpath.com>
Signed-off-by: Greg Bock <greg.bock@stackpath.com> Co-Authored-By: Joshua Reese <joshua.reese@stackpath.com>
Allow pod to specify cluster default network in annotations, When more than one cluster network is available.
Create a new field 'k8s.v1.cni.cncf.io/default-network' in pod annotations, which is used to overwrite the cluster default network defined in Multus config file.
Fix #158