Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entrypoint] Adds one-shot CRIO restart, plus renames source CNI conf to .old #366

Merged

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Aug 28, 2019

Two changes:

  • Makes CRIO restart a one-shot, it can only happen once per script run
  • Restore capability to rename source CNI config to .old when not using the watch loop

@s1061123 -- can you check and see if the condition for the rename of the file looks like what we should be doing? Thank you!

@dougbtv dougbtv requested a review from s1061123 August 28, 2019 18:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 860

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.516%

Totals Coverage Status
Change from base Build 859: 0.0%
Covered Lines: 941
Relevant Lines: 1280

💛 - Coveralls

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dougbtv dougbtv merged commit 59a2673 into k8snetworkplumbingwg:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants