Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updates daemonset for Kube 1.16, also docs and adds pre-1.16 daemonset #381

Merged
merged 3 commits into from
Oct 10, 2019

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented Sep 19, 2019

A few issues here...

  • We will need to update the referenced image tag in the daemonset, as this plans to use the --cni-version= flag which isn't available in the v3.2 tag.
  • This is a WIP as I'm still experiencing some issues...

Primarily somehow the generated delegates isn't looking exactly perfect, we're hitting this error when we spin up a pod...

Events:
  Type     Reason                  Age        From                             Message
  ----     ------                  ----       ----                             -------
  Normal   Scheduled               <unknown>  default-scheduler                Successfully assigned default/samplepod to kube-singlehost-master
  Warning  FailedCreatePodSandBox  4s         kubelet, kube-singlehost-master  Failed create pod sandbox: rpc error: code = Unknown desc = failed to set up sandbox container "d4cd9bc70e666ba3f03f57111e759bbe84780f43a7022e42b8a153e940640a5b" network for pod "samplepod": networkPlugin cni failed to set up pod "samplepod_default" network: Multus: Err in loading K8s Delegates k8s args: Multus: Err in getting k8s network from pod: GetPodNetwork: failed getting the delegate: getKubernetesDelegate: failed to get network resource, refer Multus README.md for the usage guide: the server could not find the requested resource
  Normal   SandboxChanged          4s         kubelet, kube-singlehost-master  Pod sandbox changed, it will be killed and re-created.
[centos@kube-singlehost-master ~]$ cat /etc/cni/net.d/00-multus.conf 
{ "cniVersion": "0.3.1", "name": "multus-cni-network", "type": "multus", "kubeconfig": "/etc/cni/net.d/multus.d/multus.kubeconfig", "delegates": [ { "name": "cbr0", "cniVersion":"0.3.1", "plugins": [ { "type": "flannel", "delegate": { "hairpinMode": true, "isDefaultGateway": true } }, { "type": "portmap", "capabilities": { "portMappings": true } } ] } ] }

In theory when this works it can...

Fixes #379

@coveralls
Copy link

coveralls commented Sep 19, 2019

Pull Request Test Coverage Report for Build 901

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.66%

Totals Coverage Status
Change from base Build 888: 0.0%
Covered Lines: 948
Relevant Lines: 1287

💛 - Coveralls

@dougbtv
Copy link
Member Author

dougbtv commented Oct 8, 2019

@s1061123 -- Tomo these changes you made look great! Thank you so much for fixing this up. This looks great by me, we can merge it at will.

Edit to add: Tested it on my local cluster and it works flawlessly.

@dougbtv dougbtv merged commit f4431cd into master Oct 10, 2019
@micw
Copy link
Contributor

micw commented Nov 13, 2019

CNI Version also needs to get added to cni-conf.json, otherwise it fails when customizing it

@s1061123 s1061123 deleted the kube-1.16-change branch January 9, 2020 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.16 support
4 participants