Changes wait.ExponentialBackoff to wait.PollImmediate #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinessindicatorfile via entrypoint parameter
dougbtv
force-pushed
the
entrypoint-wait-upstream
branch
from
e041294
to
1e6a125
Compare
s1061123
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and exposes readinessindicatorfile via entrypoint parameter.
Generally, the idea is that if we're using the ExponentialBackoff while pods are crashlooping, we're not actually saving any time. Using a poll instead allows us to pick up more quickly than Kubernetes itself does (since it's already waiting on the backoff)