Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pre-1.16 Kubernetes assets to a deprecated folder (to later remove) #500

Merged

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented May 7, 2020

Tomo mentioned that 1.16 will actually fall out of community support at the 1.19 timeframe. So, I think we should also probably think about moving our pre-1.16 assets into a deprecated folder, and we'll remove those later.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8d0cd0544-PR-500

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.939%

Totals Coverage Status
Change from base Build b8540e190: 0.0%
Covered Lines: 1098
Relevant Lines: 1485

💛 - Coveralls

Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbtv thank you for the PR! It looks good to me.

Oh, we can merge it because pre-1.16 means <1.16... (I misunderstood it).

@s1061123 s1061123 merged commit ec5fd6c into k8snetworkplumbingwg:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants