Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deviceid in clusterNetwork #506

Merged

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented May 19, 2020

It takes care of issue #501

@s1061123 s1061123 requested a review from dougbtv May 19, 2020 05:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build fc48f8a7b-PR-506

  • 41 of 61 (67.21%) changed or added relevant lines in 2 files are covered.
  • 21 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.8%) to 72.136%

Changes Missing Coverage Covered Lines Changed/Added Lines %
multus/multus.go 14 20 70.0%
k8sclient/k8sclient.go 27 41 65.85%
Files with Coverage Reduction New Missed Lines %
k8sclient/k8sclient.go 21 70.97%
Totals Coverage Status
Change from base Build 4eac66035: -1.8%
Covered Lines: 1064
Relevant Lines: 1475

💛 - Coveralls

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tomo! (sorry for late review)

@s1061123 s1061123 merged commit c976f6b into k8snetworkplumbingwg:master May 28, 2020
@s1061123 s1061123 deleted the dev/clusternet-device-id branch May 28, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants