Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify image repo URL explicitly #550

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

s1061123
Copy link
Member

This fix supplies domain for container image repo because
in some runtime configuration, 'docker.io' is not specified as
default container repository url.

This fix supplies domain for container image repo because
in some runtime configuration, 'docker.io' is not specified as
default container repository url.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 232187697

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.997%

Totals Coverage Status
Change from base Build 216836786: 0.0%
Covered Lines: 1082
Relevant Lines: 1524

💛 - Coveralls

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbtv dougbtv merged commit 2dab322 into k8snetworkplumbingwg:master Aug 31, 2020
@s1061123 s1061123 deleted the fix/image-url branch August 31, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants