Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes dependencies to v0.18.3 #571

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

Billy99
Copy link
Contributor

@Billy99 Billy99 commented Oct 23, 2020

No description provided.

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Oct 23, 2020

Pull Request Test Coverage Report for Build 324841959

  • 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.997%

Changes Missing Coverage Covered Lines Changed/Added Lines %
k8sclient/k8sclient.go 4 5 80.0%
Totals Coverage Status
Change from base Build 256586589: 0.0%
Covered Lines: 1082
Relevant Lines: 1524

💛 - Coveralls

Signed-off-by: Billy McFall <22157057+Billy99@users.noreply.github.com>
@Billy99
Copy link
Contributor Author

Billy99 commented Oct 23, 2020

@dougbtv PTAL

@dougbtv
Copy link
Member

dougbtv commented Oct 27, 2020

Thanks for the PR Billy, appreciate it! Looks good.

Just an FYI for anyone else dropping by, this is necessary in general to catch up with the k8s libs, but, specifically for upcoming improvements for the device id enhancement to the NPWG spec.

@dougbtv dougbtv merged commit 36d3874 into k8snetworkplumbingwg:master Oct 27, 2020
@Billy99 Billy99 deleted the billy99-k8s-rebase branch October 27, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants