Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve OpenVINO sources during build.rs instead of as a Git submodule #4

Open
abrown opened this issue Jan 20, 2021 · 0 comments
Open
Labels
idea A possible change, but needs more discussion

Comments

@abrown
Copy link
Contributor

abrown commented Jan 20, 2021

When building openvino-rs, if there is no installed version of OpenVINO available, Cargo attempts to build OpenVINO itself using the sources pulled in as a Git submodule. The sources do not fit in to the 10MB crate limit, so this build option will not work for users of openvino-rs (hence the addition of OPENVINO_SKIP_LINKING to allow, e.g., docs.rs to build the crate).

Instead, we could add git2 as a dev dependency and pull the sources from there to build. This is not optimal for several reasons: it is slow and it alters the sources during a Cargo build (an anti-pattern). There are examples of this type of thing being done, though; intel-mkl-src is pulling binaries from S3.

Alternately, the "build from source" should just be removed.

@abrown abrown added the idea A possible change, but needs more discussion label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea A possible change, but needs more discussion
Projects
None yet
Development

No branches or pull requests

1 participant