Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

Repo cleanups. #53

Closed
kalyankondapally opened this issue Sep 10, 2013 · 4 comments
Closed

Repo cleanups. #53

kalyankondapally opened this issue Sep 10, 2013 · 4 comments

Comments

@kalyankondapally
Copy link
Contributor

Listing down issues we need to tackle to clean up the repo:
1)Namespace conflicts. We seem to be using ui/content namespace for all classes under Wayland. We should come up with a better name for namespace used by these classes.
2)Wayland.gyp isn't functional. If the intention is to have it build wayland toolkit than we should fix it or remove it from repo.
3)Remove all un-necessary includes in *.h, *.cc

@kalyankondapally
Copy link
Contributor Author

1 and 3 should be started after IPC work gets merged. 2 is something we can already start.

Also I see that we have a lot of indentation issues. Cross checking chromium sources:

4)Headers should use indentation of 1 and sources use indentation of 2 spaces.
5) There are Places in our sources/headers where we wrap files below 80 columns or don't at all. Need to fix these for sake of consistency.

@kalyankondapally
Copy link
Contributor Author

@kalyankondapally
Copy link
Contributor Author

Now, missing is only to check: Function declaration order should match function definition order.

@kalyankondapally
Copy link
Contributor Author

#68 #70

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant