You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thank you for the suggestions. Those refactorings are a good thing to do. As you can imagine we are also developing the support of next gen CPUs in PCM internally. If one restructures the code in this repository then this needs to be re-done in the internal version as well. In my experience this can't be done automatically by git for larger changes, there were many merge conflicts which had to be resolved manually. If you would like to contribute I would suggest to start with smaller things which are unlikely to conflict:
Remove useless C includes like string.h.
Move some includes (like <sys/_cpuset.h>) under extern "C" {}.
In my experience this can't be done automatically by git for larger changes, there were many merge conflicts which had to be resolved manually.
Of course, this cannot be done automatically. You are right.
I'm not familiar with the development process in your company or department, so I can't give specific advices.
But I can try to help with the code, since I worked on a large project (hundreds of millions of lines of code in ancient C++).
A common way to work with a process when you have two main repositories that you can make changes to is to separate the relatively constant part from the changing parts, for example adding new CPUs as plugins.
If you would like to contribute I would suggest to start with smaller things which are unlikely to conflict:
Ok, I'll try to do it.
Big refactoring is hard, but I think it can be useful in the future as the project grows.
Possible improvements:
I suggest make a list of improvements so that later can add a separate issue for each of them.
The text was updated successfully, but these errors were encountered: