Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Combinational._execute X-driving #106

Closed
mkorbel1 opened this issue Mar 29, 2022 · 0 comments · Fixed by #156
Closed

Optimize Combinational._execute X-driving #106

mkorbel1 opened this issue Mar 29, 2022 · 0 comments · Fixed by #156
Assignees
@mkorbel1
Labels
enhancement New feature or request

Comments

@mkorbel1
Copy link
Contributor

Motivation

The _execute function in Combinational currently drives all outputs to x, then executes the conditionals. This is less efficient than it could be, since Conditional.execute returns a list of signals driven.

Desired solution

Only drive signals to x if they are not driven by any other sub-Conditional as determined by the Conditional.execute function.
@mkorbel1 mkorbel1 added the enhancement New feature or request label Mar 29, 2022
@mkorbel1 mkorbel1 self-assigned this Aug 26, 2022
@mkorbel1 mkorbel1 mentioned this issue Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkorbel1 mkorbel1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve performance of Combinational execute mkorbel1/rohd
1 participant
@mkorbel1