[issue#137]: Add mechanism for reset all flop of Sequential #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chykon
reviewed
Mar 8, 2023
mkorbel1
requested changes
Mar 16, 2023
chykon
reviewed
Mar 22, 2023
mkorbel1
requested changes
Apr 6, 2023
mkorbel1
requested changes
Apr 13, 2023
mkorbel1
requested changes
May 5, 2023
mkorbel1
requested changes
May 18, 2023
test/counter_wintf_test.dart
Outdated
| @@ -32,7 +34,9 @@ class CounterInterface extends Interface<CounterDirection> { | |||
|
|
|||
| class Counter extends Module { | |||
| late final CounterInterface intf; | |||
| Counter(CounterInterface intf) { | |||
| late bool resetRoot; | |||
There was a problem hiding this comment.
i think you're not using this resetRoot anymore, delete?
mkorbel1
approved these changes
May 18, 2023
|
Fix #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Issue #137
Fix #137
Testing
Backwards-compatibility
Documentation