Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

make update should do git pull #137

Closed
poussa opened this issue Aug 24, 2016 · 2 comments
Closed

make update should do git pull #137

poussa opened this issue Aug 24, 2016 · 2 comments

Comments

@poussa
Copy link
Contributor

poussa commented Aug 24, 2016

I was expecting make update to do

  • git clone repo if it does not exists, or git pull to update to the HEAD from the origin
  • git check out the commit listed in deps/repos.txt

The git pull part missing. I ended up having an old git tree which did not have the commit id listed in repos.txt. So the tree is stuck with the cloned version.

Can we fix this?

@jprestwo
Copy link
Contributor

#142

I was thinking about this and, though I don't see anything wrong with it, it should not make a difference unless we have a specific branch/master in repos.txt. A commit ID shouldn't matter if you do a git pull after checkout (right?). Either way it couldn't hurt.

@poussa
Copy link
Contributor Author

poussa commented Sep 12, 2016

This has been already fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants