Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Thug via optional docker container #109

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Conversation

eshaan7
Copy link
Member

@eshaan7 eshaan7 commented Jul 9, 2020

  • Integrated Thug for observable (url, domain) and file (text/html) scans. With the following variants, (closes Thug integration #3)
    • Thug_URL_Info_winxpie60_SIMPLE_SCAN
    • Thug_HTML_Info_winxpie60_SIMPLE_SCAN
    • Thug_URL_Info_winxpie60_FULL_SCAN
    • Thug_HTML_Info_winxpie60_FULL_SCAN
    • Thug_URL_Info_linuxchrome26
    • Thug_HTML_Info_linuxchrome26
    • Thug_URL_Info_osx10chrome19
    • Thug_HTML_Info_osx10chrome19
    • Thug_URL_Info_nexuschrome18
    • Thug_HTML_Info_nexuschrome18

The SIMPLE_SCAN has AWIS and image processing off while they are both on for FULL_SCAN and all other variants are FULL_SCAN by default.

  • New test class called FileAnalyzerHTMLTest for testing html files. For this, I have added a page.html test-file to the test_files.zip.
  • refactored tests to prevent cyclic imports and code duplicacy.
  • Fixed bug where PEframe's log files were not created/ updating.
  • Also includes this fix Remove whitespaces around = #113.

@eshaan7 eshaan7 changed the title Dev thug integration Integrated Thug via optional docker container Jul 9, 2020
@intelowlproject intelowlproject deleted a comment from lgtm-com bot Jul 9, 2020
@eshaan7 eshaan7 force-pushed the dev-thug-integration branch 3 times, most recently from 1b3669e to 2156b04 Compare July 9, 2020 18:49
@intelowlproject intelowlproject deleted a comment from lgtm-com bot Jul 9, 2020
@intelowlproject intelowlproject deleted a comment from lgtm-com bot Jul 12, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 13, 2020

This pull request fixes 1 alert when merging 35935da into 5baba4a - view on LGTM.com

fixed alerts:

  • 1 for Potentially uninitialized local variable

@eshaan7 eshaan7 merged commit d1a775c into develop Jul 13, 2020
@eshaan7 eshaan7 mentioned this pull request Jul 13, 2020
@eshaan7 eshaan7 linked an issue Jul 13, 2020 that may be closed by this pull request
4 tasks
@eshaan7 eshaan7 deleted the dev-thug-integration branch July 13, 2020 18:16
eshaan7 added a commit that referenced this pull request Jul 14, 2020
From #107,
* analyzers now use class/OO approach
* update tasks & tests to use the new class/OO approach
* moved a few fns here & there to fix cyclic import issues
* updated contributing docs, and prettified README.md

From #109,
* added thug integration for url, domain, html file
* refactors tests, added tests for thug analyzer
* bug fixes: PEframe log not showing, lgtm alert, whitespace around = in env file

Also, bump version number to v1.1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thug integration
1 participant