Fixes #390: Split send_analysis_request into analyze_file and analyze_observable

[m0mosenpai]

Description

• New views for endpoints
• New Serializers
• Testing and Refactoring

Related issues

Fixes #390

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

• I have added tests in the Tests folder.
• The tests gave 0 errors.
• Black gave 0 errors.
• Flake gave 0 errors.

[m0mosenpai]

#547 (comment)

@eshaan7
Regarding this, It requires passing the function the file and file_name arguments. I'm not sure how i can access those values here. file_mimetype = serializers.HiddenField(default=calculate_mimetype(file_buffer, file_name))

Last case, we could also leave it the way it was since there isn't really a validation going on in this field. Just calculation. The actual filtering occurs in the filter_analyzers()

[eshaan7]

I am not sure but I think it should be possible to do like:

file_mimetype = serializers.HiddenField(default=lambda attrs: calculate_mimetype(attrs["file"], attrs["file_name"]))

[m0mosenpai]

I am not sure but I think it should be possible to do like:

file_mimetype = serializers.HiddenField(default=lambda attrs: calculate_mimetype(attrs["file"], attrs["file_name"]))

@eshaan7
I don't think this works. It says it's missing a positional argument attrs. I tried looking it up online as well but didn't find examples where they had called a function with positional arguments in HiddenField

[eshaan7]

Looks good to me. Can you run only the relevant tests on your local to test and post the screenshot here ? (inconvenience caused since the testing suite is broken for develop-2 branch)

[m0mosenpai]

API Tests:

GUI:
Observable:

FIle:

[lgtm-com]

This pull request introduces 1 alert when merging bb9da49 into 82a390f - view on LGTM.com

new alerts:

• 1 for Information exposure through an exception

[lgtm-com]

This pull request introduces 1 alert when merging 40ba84f into 82a390f - view on LGTM.com

new alerts:

• 1 for Information exposure through an exception