Can IcicleIdGenerator be used as a singleton?

[vijayrawatsan]

No description provided.

[nathankleyn]

@vijayrawatsan There's no reason why you can't create an instance of IcicleIdGenerator and wrap it in a singleton. However as it stands, IcicleIdGenerator does not offer any singleton interface to itself currently. This is primarily a design decision we took to eliminate as many forms of global state in our applications as possible.

[vijayrawatsan]

My question indirectly was, is it thread safe? Can multiple objects safely call generateId simlutaneously?

[nathankleyn]

@vijayrawatsan I believe IcicleIdGenerator itself is thread safe, although looking at RoundRobinRedisPool I suspect getNextRedis is not and would need some change to make it so. I'll raise a PR shortly that will make that particular case thread-safe, but there may be others. Any contributions to investigate and make the library thread-safe in this manner are very welcome!

[nathankleyn]

@vijayrawatsan New version is being pushed as v1.1.1 with the thread-safety fix for RoundRobinRedisPool, should be available on Maven Central shortly for you. Let us know if you spot any other thread-safety issues!

[vijayrawatsan]

@nathankleyn I did check IcicleIdGenerator it was looking thread-safe.
Also i just checked getNextRedis method looks thread-safe to me.

[nathankleyn]

@vijayrawatsan Awesome! Let us know if you run into any issues - I'll close this ticket for now but feel free to open again if you hit a snag!