Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No rubocop rake task on deploy #296

Closed
mathias opened this issue Jan 6, 2017 · 2 comments
Closed

No rubocop rake task on deploy #296

mathias opened this issue Jan 6, 2017 · 2 comments

Comments

@mathias
Copy link
Contributor

mathias commented Jan 6, 2017

Seeing this when deploying on Heroku:

remote:        LoadError: cannot load such file -- rubocop/rake_task
remote:        /tmp/build_4e2a1988938618c73e23e23d226ec1be/lib/tasks/rubocop.rake:2:in `require'
remote:        /tmp/build_4e2a1988938618c73e23e23d226ec1be/lib/tasks/rubocop.rake:2:in `<top (required)>'
remote:        /tmp/build_4e2a1988938618c73e23e23d226ec1be/Rakefile:7:in `load'
remote:        /tmp/build_4e2a1988938618c73e23e23d226ec1be/Rakefile:7:in `block in <top (required)>'
remote:        /tmp/build_4e2a1988938618c73e23e23d226ec1be/Rakefile:7:in `each'
remote:        /tmp/build_4e2a1988938618c73e23e23d226ec1be/Rakefile:7:in `<top (required)>'

Do we need to guard unless it is in dev or test environment when loading that file?

@mathias
Copy link
Contributor Author

mathias commented Jan 6, 2017

Ah, I see we could just copy this rake task style: https://github.com/interagent/pliny/blob/master/lib/template/lib/tasks/spec.rake#L2-L7

@gudmundur
Copy link
Member

@mathias I've PR'ed a fix to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants