Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Intercom binary and dSYMs #413

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

Br1an-Boyle
Copy link
Contributor

No description provided.

@Br1an-Boyle Br1an-Boyle merged commit 17ab76d into master Jul 3, 2023
@Br1an-Boyle Br1an-Boyle deleted the brian/remove_binary branch July 3, 2023 09:39
@mikklfr
Copy link

mikklfr commented Jul 3, 2023

👋 This breaks our https://pub.dev/packages/intercom_flutter usage

Lexical or Preprocessor Issue (Xcode): 'Intercom/Intercom.h' file not found
/Users/runner/.pub-cache/hosted/pub.dev/intercom_flutter-7.6.9/ios/Classes/IntercomFlutterPlugin.m:1:8

@Br1an-Boyle
Copy link
Contributor Author

Br1an-Boyle commented Jul 3, 2023

Hi @mikklfr
Thanks for flagging this. Fixing it now.

Br1an-Boyle added a commit that referenced this pull request Jul 3, 2023
@mikklfr
Copy link

mikklfr commented Jul 3, 2023

Thanks for your quick response 👍

We are only using the "flutter" way of adding a dependency so things are a bit hidden from the flutter dev perspective.
Under the hood in iOS, the package seems to depend on that .h file and I think that the version fetched by this plugin is not locked correctly, so latest code seems to be pulled from cocoapods leading to the missing .h compilation unit.

Here is the code that seems to fail in the flutter wrapper
https://github.com/v3rm0n/intercom_flutter/blob/master/intercom_flutter/ios/Classes/IntercomFlutterPlugin.m

Br1an-Boyle added a commit that referenced this pull request Jul 3, 2023
@Br1an-Boyle
Copy link
Contributor Author

@mikklfr should be fixed now.

@matiasfic
Copy link

matiasfic commented Jul 3, 2023

This also breaks Capacitor community plugin (https://github.com/capacitor-community/intercom)

error: no such module 'Intercom'

@Br1an-Boyle
Copy link
Contributor Author

@matiasfic Working on a fix to address this now.
Will post here once the issue has been resolved.

@simplenotezy
Copy link

Thanks for your quick response 👍

We are only using the "flutter" way of adding a dependency so things are a bit hidden from the flutter dev perspective. Under the hood in iOS, the package seems to depend on that .h file and I think that the version fetched by this plugin is not locked correctly, so latest code seems to be pulled from cocoapods leading to the missing .h compilation unit.

Here is the code that seems to fail in the flutter wrapper https://github.com/v3rm0n/intercom_flutter/blob/master/intercom_flutter/ios/Classes/IntercomFlutterPlugin.m

Did you find a workaround to revert? I believe, as you said, the previous version is not locked correctly, so it keeps fetching the new faulty version.

@Br1an-Boyle
Copy link
Contributor Author

This issue has been resolved. Thanks to all for reporting it.

@matiasfic
Copy link

I can confirm it works fine. Remember to delete local pods cache.
pod cache clean 'Intercom' --all

@mikklfr
Copy link

mikklfr commented Jul 3, 2023

Working fine now, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants