Consider renaming settlement related variables

[gakonst]

I think we can rename the min_balance variable to something like: credit_limit. It's slightly clearer I think.

settle_to could also be renamed to something more descriptive, not sure yet what: I'm thinking along the lines of a "safe floor" such that settlements aren't triggered too often.

Sidenote: Does it ever make sense to set settle_to above threshold? Think not?

https://github.com/emschwartz/interledger-rs/blob/master/crates/interledger-api/src/lib.rs#L61
https://github.com/emschwartz/interledger-rs/blob/master/crates/interledger-store-redis/src/account.rs#L35

[emschwartz]

Credit limit seems fine for negative minimum balances but strange if you ever had a positive minimum balance (it would be a negative credit limit). Having a positive minimum balance would be one way to implement a kind of signup fee, though there might be more straightforward ways of implementing it.

"Safe floor" seems less descriptive to me. Happy to consider alternatives but settle_to seems fine to me because it is the amount you will settle the balance down to.

Sidenote: Does it ever make sense to set settle_to above threshold? Think not?

Agreed that that doesn't make sense

[emschwartz]

@gakonst Do you still think we should change the names or can we close this issue?

[gakonst]

I've got used to them at this point so let's close it.

[kincaidoneil]

Reopening this since it's confusing that the maximum balance in the settlement RFC and ilp-connector is the minimum balance in the Rust and Java connectors, since they each define positive/negative balances differently.

Evan agrees that renaming minimum to "credit limit" is clearer, but some open questions are:

• Can we implement this in a backwards compatible way? (e.g. "minimum" may still be used as an alias for "credit limit")
• Should credit_limit be limited to non-negative values? (I think this is the most intuitive interpretation, since other things like sign-up fees can be implemented within settlement engines)

[emschwartz]

We should make a decision on this issue before finalizing #557