Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Notifications for Incoming STREAM Packets #197

Closed
emschwartz opened this issue Aug 7, 2019 · 2 comments
Closed

API: Notifications for Incoming STREAM Packets #197

emschwartz opened this issue Aug 7, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@emschwartz
Copy link
Member

emschwartz commented Aug 7, 2019

Websocket endpoint on the API that sends out notifications about incoming STREAM packets with the following information:

  • STREAM ID / Payment Pointer
  • Sender Payment Pointer (if possible)
  • Amount
  • Timestamp
  • Data from packet

Originally part of #128

@emschwartz
Copy link
Member Author

We may actually want to leave the data out of the initial version of this API. The STREAM protocol is designed to ensure that the data is received in the correct order with no gaps, even if it is split across multiple packets. However, it's possible that the data will arrive out of order, and even possible that the sender could send two packets with some bytes overlapping. It would be a pain to handle these cases in the client to this API so it would be better to use a stateful STREAM receiver when we want to use data sent over STREAM.

@emschwartz
Copy link
Member Author

Resolved by #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants