Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge accounts package into connector package #53

Closed
cairin opened this issue Jul 20, 2021 · 0 comments · Fixed by #59
Closed

Merge accounts package into connector package #53

cairin opened this issue Jul 20, 2021 · 0 comments · Fixed by #59
Labels
type: architecture Structural considerations type: enhancement New feature or request

Comments

@cairin
Copy link
Collaborator

cairin commented Jul 20, 2021

Problem

The current implementation of the accounts and connector packages is conflicted. They are implemented as separate packages. However, the accounts package is being imported into the connector package as if it were a module, when it is implemented as a standalone service.

Constraints

  • The connector logic and the ilp accounts logic should be separate.
    • They should be isolated services.
  • The connector service imports types from the accounts service.
  • The connector and accounts service should communicate in-process for performance.

Proposal

This proposal follows from #52, to be implemented alongside/after.

The connector package should be renamed the interledger package, and the accounts logic (currently in the accounts package) should be implemented as a service within the new interledger package.

@cairin cairin changed the title Merge accounts service into connector service Merge accounts package into connector package Jul 20, 2021
@cairin cairin added type: architecture Structural considerations type: enhancement New feature or request labels Jul 20, 2021
@cairin cairin linked a pull request Jul 23, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: architecture Structural considerations type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant