Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grants detail page - make it better #1325

Closed
Tymmmy opened this issue Apr 25, 2024 · 0 comments · Fixed by #1355
Closed

Grants detail page - make it better #1325

Tymmmy opened this issue Apr 25, 2024 · 0 comments · Fixed by #1355
Assignees
@rico191013
Labels
package: boutique/frontend Boutique frontend implementations package: wallet/backend Wallet backend implementations priority: high

Comments

@Tymmmy
Copy link
Contributor

Tymmmy commented Apr 25, 2024

We need to make a human readable string from the grant interval - Grants detail page when having a web monetization grant

https://github.com/tolu/ISO8601-duration?tab=readme-ov-file#example
https://en.wikipedia.org/wiki/ISO_8601#Repeating_intervals
We will probably need to parse this ourselves (maybe another library in the open-payments repo?)

image
@Tymmmy Tymmmy added package: wallet/backend Wallet backend implementations package: boutique/frontend Boutique frontend implementations labels Apr 25, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Testnet Apr 25, 2024
@rico191013 rico191013 self-assigned this May 16, 2024
@rico191013 rico191013 mentioned this issue May 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Testnet Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rico191013 rico191013

Labels
package: boutique/frontend Boutique frontend implementations package: wallet/backend Wallet backend implementations priority: high
Projects
Testnet
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: parse open-payments intervals interledger/testnet
2 participants
@rico191013 @Tymmmy