Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "current class" filters to left filter bar #9

Closed
yochannah opened this Issue Aug 1, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@yochannah
Copy link
Member

yochannah commented Aug 1, 2018

For now this would simply be adding Gene and Protein filters (dependent on the active tab) to left - probably these will work ok all mines!

  • This will mean we can allow IN queries if user is authenticated
  • Also allow LOOKUP query with multiple identifiers pasted in or a single identifier (autocomplete possible here? Maybe not wise?)

This should be dynamic and not hard coded to Gene and Protein classes. I would suggest fixing this after #8 is implemented.

@yochannah yochannah added this to the Version 1.1 milestone Aug 1, 2018

@AdrianBZG

This comment has been minimized.

Copy link
Member

AdrianBZG commented Aug 2, 2018

@yochannah This means to add a new filter to the sidebar where the user can choose Gene, Protein or both? And then remove the buttons on top?

@yochannah

This comment has been minimized.

Copy link
Member Author

yochannah commented Aug 24, 2018

We don't want to remove the buttons on the top. Maybe consider the buttons on the top the view, and the buttons on the left the filters?

@AdrianBZG

This comment has been minimized.

Copy link
Member

AdrianBZG commented Aug 24, 2018

@yochannah So if I understand correctly, the idea is to add a new filter that, depending on current view, works e.g. like this:

  • If I'm in Proteins view, the user can specify a list in a textbox, and by filtering, the constraint applied is:

{
select: ["Protein.*"],
where: [["genes", "IN", "list from the textbox"]]
}

  • If in Genes view, it will be:

{
select: ["Gene.*"],
where: [["genes", "IN", "list from the textbox"]]
}

Or I'm getting it wrong?

@yochannah

This comment has been minimized.

Copy link
Member Author

yochannah commented Aug 24, 2018

that's exactly it!

We'd also want the user to be able to type a single identifier and run a LOOKUP query, e.g. type "adh" and show the single gene adh in the view, or type "adh, fkh, bsk" and show all three in the view.

I'm not sure if that should be one input or two - whatever's less confusing. A single smart box with typeahead might be nice?

AdrianBZG added a commit to AdrianBZG/InterMine-Data-Browser-Tool that referenced this issue Sep 11, 2018

AdrianBZG added a commit to AdrianBZG/InterMine-Data-Browser-Tool that referenced this issue Sep 16, 2018

@AdrianBZG

This comment has been minimized.

Copy link
Member

AdrianBZG commented Sep 16, 2018

@yochannah This looks like its working 😄

image

image

http://im-browser-prototype.herokuapp.com/

@AdrianBZG AdrianBZG closed this Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.