Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template constraints not always offering all the constraint options you might expect. #32

Closed
yochannah opened this issue Jan 10, 2017 · 5 comments

Comments

@yochannah
Copy link
Member

for example, we might expect to see equals in the dropdown list:

image

Possible place to start looking: https://github.com/intermine/redgenes/blob/dev/src/cljs/redgenes/components/ui/constraint.cljs#L7

@joshkh
Copy link
Collaborator

joshkh commented Jan 10, 2017

This is because the constraint "Probe Set" is at the class level, not the attribute level, so the constraint is limited to "LOOKUP" operators and list operators. This is in line with Intermine 1's behaviour.

@yochannah
Copy link
Member Author

Rachel has also commented "Optional constraints are missing from templates (e.g. Gene → Orthologues)."

@yochannah
Copy link
Member Author

@joshkh did we add optional constraints at some point or is it still to-do?

@joshkh
Copy link
Collaborator

joshkh commented Mar 19, 2018

@yochannah Yup, templates now have optional constraints:

image

@yochannah
Copy link
Member Author

💥 Issue is ded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants