-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from docker-compse.yml files to docker python library #2
Comments
I’d like to take this issue :) |
I cant take this one |
Hello all! Due to there being a lot of interest in this project compared to the amount of issues, we've decided to not assign issues and allow anyone interested to submit a PR. Obviously we won't be able to merge all the PRs, so don't worry about being first. All PRs whether merged or not, will be part of our evaluation of an intern. It would also be great if you could explain your approach and rationale in the PR description. This only needs to be as long or as in depth as you feel it needs to be for the specific task. In summary, just go ahead and start working on this if you want! |
I'd like to work on this issue too |
@uosl Hi, a question! When trasnferring .yml to py docker, should all the environment variables be preserved? And also, should the docker.py file changed accordingly? |
@Mightynasty You can start with preserving only the UID and GID environment variables which are currently passed to docker-compose in docker.py, using the equivalent py-docker functionality instead. We will probably add support for the remaining ones to be passed through as CLI arguments in the future, but you don't need to handle these now. |
@uosl should we close this issue? |
yup! |
Problem
Intermine_boot uses
docker-compose.yml
files from docker-intermine-gradle repo for launching containers. Intermine_boot clonesdocker-intermine-gradle
repo for the files and then open up a shell to execute docker-compose commands.This approach works, but we cannot guarantee predictable behaviour with this. What if files in the
docker-intermine-gradle
changes? Also, we have to clone entiredocker-intermine-gradle
for just two files.Outline of a Solution
We want to use docker-py library.
Translate
docker-compose.yml
into python functions usingdocker-py
library.Then replace the old way of starting containers with these new functions.
The text was updated successfully, but these errors were encountered: