Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #3

Open
leoank opened this issue Mar 12, 2020 · 7 comments
Open

Add tests #3

leoank opened this issue Mar 12, 2020 · 7 comments

Comments

@leoank
Copy link
Member

leoank commented Mar 12, 2020

Problem

Intermine_boot have no tests

Outline of a Solution

Add Unit tests using pytest library

@mkhoshle
Copy link

Hello, I am interested in working on this issue. Could you please assign it to me?

@mkhoshle
Copy link

mkhoshle commented Mar 12, 2020

@leoank Do you need to have Tests as part of the application code or Tests outside application code? Which one would be preferred?

Also, would it be possible to provide me with some explanations, links, websites, etc so that I can understand what do is this package supposed to do? I am not really sure what to start with and this is my first time doing it.

@shreyagupta30
Copy link

@leoank I am interested in working on this issue as well.

@heralden
Copy link
Member

Hello all! Due to there being a lot of interest in this project compared to the amount of issues, we've decided to not assign issues and allow anyone interested to submit a PR. Obviously we won't be able to merge all the PRs, so don't worry about being first. All PRs whether merged or not, will be part of our evaluation of an intern.

It would also be great if you could explain your approach and rationale in the PR description. This only needs to be as long or as in depth as you feel it needs to be for the specific task.

@heralden
Copy link
Member

@mkhoshle I updated the README with a description. The goal of this tool is to automate https://intermine.readthedocs.io/en/latest/get-started/tutorial/ (mostly the sysadmin stuff, as the configuration is tackled in other repos) by using dockerfiles from https://github.com/intermine/docker-intermine-gradle. Right now it can build and deploy a biotestmine (simple InterMine instance for testing, using a small malaria dataset) on your local docker daemon.

@heralden
Copy link
Member

I don't think there are any useful unit tests we can write at this point, so we can start with what I suggested in #4.

As a suggestion for a test to run during CI, how about intermine_boot start local, then wait up to 15 minutes running curl http://localhost:9999/biotestmine/service/version until it returns a successful response (failing if it doesn't finish after the waiting time). You might have to test with Travis CI whether 15 minutes is enough time.

@leoank
Copy link
Member Author

leoank commented Mar 16, 2020

@mkhoshle as @uosl suggested, Right now, the most useful test would be to test whether intermine boot can successfully launch biotestmine on different platforms(Linux, MacOS, Windows?). However, this is not a trivial test to write. You need to come up with some creative way to do this neatly. Try to think of what will happen when intermine boot fails. What error messages can we expect?

Also, make a test directory at the root of the project and add tests there. You can take inspiration from any project who do their application testing inside docker containers. I will try to add some links here soon.

This was referenced Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants