Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--build-im doesn't seem to work #34

Closed
heralden opened this issue Jul 16, 2020 · 3 comments
Closed

--build-im doesn't seem to work #34

heralden opened this issue Jul 16, 2020 · 3 comments

Comments

@heralden
Copy link
Member

As a reminder, --build-im builds InterMine before building Biotestmine (so a custom build of InterMine can be used to build Biotestmine).

This might be simply because the dockerhub containers are outdated, so we should test this again combined with --build-images once #33 is fixed.

@22PoojaGaur
Copy link
Member

Hi @uosl

what is the difference between --build-im and --build-images flags?

Their help definition looks similar to me (given how we are building mine).

@heralden
Copy link
Member Author

--build-im specifies that you want to build a custom version of InterMine (usually you'll use --im-repo and/or --im-branch to point to your fork of Intermine which differs from the official one uploaded to maven, that is fetched automatically when building a mine). By Intermine here, I don't mean a mine instance like Biotestmine, but the actual program that is used to build a mine instance.

--build-images specifies that you want to build the docker images from the dockerfiles, instead of pulling the prebuilt images from dockerhub.

We could probably improve their help definition, or rename im to intermine to be less ambiguous. (I think at some point we're going to redo all the flags and arguments to make things clearer, probably when we do a major release.)

I will look into this issue again once I've had a look at #33, as they might be related.

@heralden
Copy link
Member Author

This also works with the submodule initialized!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants