Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev measurement may hang interminably #54

Closed
jesteria opened this issue Jul 26, 2023 · 1 comment
Closed

dev measurement may hang interminably #54

jesteria opened this issue Jul 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jesteria
Copy link
Member

🐞 Bug Report

The command underlying the dev measurement – nmap -sn … – may hang without end, i.e. without any timeout, without ever returning a result.

Not only does this break this measurement – it also may interfere with measurements requesting that they are run in isolation of other measurements (e.g. speed measurements).

The underlying cause of such a hang is almost certainly environmental and its remediation is out of scope. However, this measurement should apply a timeout to the nmap command invocation, such that the issue is made explicit, and such that this measurement does not interfere with the execution of others.

Steps to Reproduce

On a machine with faulty networking – e.g. a vanilla Docker container – and with Netrics v0.0.1 installed:

netrics debug run dev

Additional Information

In addition to the above remediation, a framework-level default measurement timeout should be considered.

@jesteria jesteria added the bug Something isn't working label Jul 26, 2023
@jesteria
Copy link
Member Author

See: internet-equity/fate#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant