Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: hamburger icon invisible on mobile #99

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Apr 24, 2019

Closes #98

The root issue is that the SVG is not displaying (for some reason), but for now we show the PNG by default instead.

NOTE I don't have a local copy of this running, so didn't try building/compiling it or anything. Just made the changes directly. Here's the before/after from applying the changes in devtools:

Before After
image image

@mekarpeles mekarpeles requested a review from rchrd2 April 24, 2019 19:24
Copy link
Member

@mekarpeles mekarpeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@iisa iisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with updated note to properly fix the svg

@iisa
Copy link
Contributor

iisa commented Apr 24, 2019

Created a new issue #100 - to actually fix the broken SVG

@bfalling
Copy link
Contributor

LGTM as well

@mekarpeles mekarpeles merged commit 9d5becd into internetarchive:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot zoom in on mobile
5 participants