Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate /libraries route, keep backend logic #1579

Closed
jdlrobson opened this issue Nov 13, 2018 · 3 comments
Closed

Deprecate /libraries route, keep backend logic #1579

jdlrobson opened this issue Nov 13, 2018 · 3 comments
Assignees
@jdlrobson
Labels
Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed]

Comments

@jdlrobson
Copy link
Collaborator

jdlrobson commented Nov 13, 2018 •
edited

We are trying to get to one by making all our pages "v2".

The following entry points do not need porting but should not be accessible. Remove any associated templates and get handlers:
https://openlibrary.org/libraries
https://openlibrary.org/libraries/register
@jdlrobson
Copy link
Collaborator Author

We chatted about this today in the call and decided to remove the frontend for this (but keep backend)

@mekarpeles mekarpeles changed the title Libraries page should be v2 Deprecate /libraries route, keep backend logic Nov 13, 2018
@hornc hornc mentioned this issue Nov 13, 2018
Closed
@hornc
Copy link
Collaborator

hornc commented Nov 13, 2018

See also #337

@jdlrobson
Copy link
Collaborator Author

Hey @hornc @mekarpeles

so i took a look at this and want to clarify what we mean by keeping backend logic. Is removing all GET and POSTs that use templates fine? Many of the posts render templates on the frontend but im not sure if this counts as "backend" logic.

jdlrobson added a commit to jdlrobson/openlibrary that referenced this issue Nov 22, 2018
@jdlrobson
Remove libraries user facing endpoints
d8c9ac2 
Per discussion all user facing pages regarding the
libraries feature and their associated templates are
removed.

APIs are retained for future usage if needed.
Various templates remain - these output email confirmations
after POSTs and help a txt api endpoint. These have all
been documented for future reference

Fixes: internetarchive#1579
@jdlrobson jdlrobson self-assigned this Nov 22, 2018
@jdlrobson jdlrobson mentioned this issue Nov 22, 2018
Merged
mekarpeles pushed a commit that referenced this issue Nov 22, 2018
@jdlrobson @mekarpeles
1579 - disable frontend portions of libraries routes (#1611)
2c9274d 
* Disable the frontend for borrow/about

This is erroring due to referencing a missing template
so should be disabled.

* Remove libraries user facing endpoints

Per discussion all user facing pages regarding the
libraries feature and their associated templates are
removed.

APIs are retained for future usage if needed.
Various templates remain - these output email confirmations
after POSTs and help a txt api endpoint. These have all
been documented for future reference

Fixes: #1579
@brad2014 brad2014 added the Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] label May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdlrobson jdlrobson

Labels
Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdlrobson @hornc @brad2014