Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve (with redirects) Works w/ 0 Editions resulting from Workbot translation associations historical bug #2727

Closed
9 tasks done
mekarpeles opened this issue Dec 13, 2019 · 8 comments
Assignees
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@mekarpeles mekarpeles added the Type: Bug Something isn't working. [managed] label Dec 13, 2019
@xayhewalo xayhewalo added Affects: Data Issues that affect book/author metadata or user/account data. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged labels Dec 13, 2019
@hornc
Copy link
Collaborator

hornc commented Dec 13, 2019

There are specific examples of a bigger issue #44, deleting these specifically is low value and the incorrect thing to do. (IMO)

@hornc
Copy link
Collaborator

hornc commented Dec 13, 2019

I have some specific work in progress that has been paused on this, which is most of the way to a solution, so when it is prioritised, I can resume form where I left off.

@hornc hornc changed the title Delete these: Works w/ 0 Editions Resolve (with redirects) Works w/ 0 Editions resulting from Workbot translation associations historical bug Dec 13, 2019
@hornc hornc added this to To do in lead board test Dec 18, 2019
@mekarpeles mekarpeles added the Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] label Dec 18, 2019
@BrittanyBunk
Copy link
Contributor

Can't we have it to where if someone moves all the editions out of the work, it goes away (especially because it was an error for it to exist)?

@tfmorris
Copy link
Contributor

I have some specific work in progress that has been paused on this, which is most of the way to a solution

@hornc Is there a branch with this work on it?

@hornc hornc added Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] and removed Type: Bug Something isn't working. [managed] labels Jul 30, 2020
@hornc
Copy link
Collaborator

hornc commented Aug 4, 2020

The index hasn't quite caught up, but many classical authors had 100s or 1000s of extra (empty) works,
e.g Plutarch
image

Now has 892 works: https://openlibrary.org/authors/OL58120A/Plutarch

@BrittanyBunk
Copy link
Contributor

So glad this is being worked on. It would take forever to do this manually.

@LeadSongDog
Copy link

LeadSongDog commented Aug 7, 2020

@hornc Of those 892 work records, there are currently about 722 that have editions. Of course the ultimate number should be far lower as redundant works get merged. Any reason to continue displaying voided works on the author pages?

@hornc
Copy link
Collaborator

hornc commented Aug 13, 2020

My bot made ~104108 redirects from works left without editions. The WorkBot history contained the work id to which the editions were moved, so the redirect targets contain the original editions.

The bot examined all of Work Bot's history and used the available data on any edit with the comment merge works to resolve the editionless works. If there editionless works created by other means, they will have to be located by some other means.

@hornc hornc closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
No open projects
Development

No branches or pull requests

6 participants