Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display /subjects page in columns #3287

Closed
cdrini opened this issue Mar 31, 2020 · 1 comment · Fixed by #3453 or #3454
Closed

Display /subjects page in columns #3287

cdrini opened this issue Mar 31, 2020 · 1 comment · Fixed by #3453 or #3454
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Theme: CSS Issues related to CSS stylesheets. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Mar 31, 2020

The subjects page was meant to be displayed in columns, but

Steps to Reproduce

  1. Go to https://openlibrary.org/subjects
Expected Actual
Something like this: image image

Details

  • Logged in (Y/N)? Y
  • Browser type/version? FF74
  • Operating system? Win10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Find a way to add some CSS to this page. Since this is an infogami wiki page, we're not really sure how to add css to it :/ Any attempt to add e.g. <style>, or style="..." to the wiki page's markup failed (looks like it's not allowed), so we need to a way to add CSS to this while leaving the actual HTML file here (or somewhere?) as a wiki page for easy editing.

Related files

None 😬

Stakeholders

@cdrini cdrini added Type: Bug Something isn't working. [managed] Theme: CSS Issues related to CSS stylesheets. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Mar 31, 2020
@BrittanyBunk
Copy link
Contributor

BrittanyBunk commented Apr 1, 2020

Is there a way to make it an array or table?

TL:DR I'm no expert, but:

  • I did look at the homepage - and it really is a confusion of sorts - has a mix of javascript, css, and of course some stuff (like the bots) are written in python.
  • From building websites, usually the CSS is built separately from the HTML, but kind of 'inserted in' so the html code reads it.
  • The OL homepage looks like it uses a separate CSS file for its CSS coding, so maybe that could be done too - like create a separate CSS file that an HTML code could call upon?
    image

@xayhewalo xayhewalo added Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Theme: CSS Issues related to CSS stylesheets. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
3 participants