Subject Page changed into columns #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fatimanaz <7fatimanaz@gmail.com> Co-authored-by: tabshaikh <tabish.shaikh91@gmail.com>
Co-authored-by: Fatimanaz <7fatimanaz@gmail.com>
mekarpeles
reviewed
May 9, 2020
There was a problem hiding this comment.
LGTM
Can we please add a rule for #subjectsPage ul { display: inline-block; }? Then @cdrini and I can move the <h3> into the <ul> and we won't have strange line-breaking :)
Co-authored-by: Fatimanaz <7fatimanaz@gmail.com> Co-authored-by: tabshaikh <tabish.shaikh91@gmail.com>
mekarpeles
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3287
Technical
Markup was added by @cdrini by editing the page.
Screenshot
Stakeholders