Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate and dangerously placed DELETE button on author edit form #4101

Closed
seabelis opened this issue Nov 16, 2020 · 1 comment · Fixed by #4104
Closed

Duplicate and dangerously placed DELETE button on author edit form #4101

seabelis opened this issue Nov 16, 2020 · 1 comment · Fixed by #4104
Labels
Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Milestone
Sprint 2020-12

Comments

@seabelis
Copy link
Collaborator

A duplicate DELETE button is on the author edit form. Additionally it is placed in a dangerous location just below the SAVE button and highlighted in orange.

Evidence / Screenshot (if possible)

Screenshot 2020-11-16 at 16 13 28

Relevant url?

https://openlibrary.org/authors/OL...A/[author]/edit

Steps to Reproduce

  1. Go to any author profile
  2. Click edit button.
  3. Scroll to bottom where SAVE is and see also the two DELETE buttons.
  • Actual:
  • Expected:

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders
@seabelis seabelis added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Nov 16, 2020
@mekarpeles mekarpeles added the Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] label Nov 16, 2020
@nk4456542 nk4456542 mentioned this issue Nov 17, 2020
Merged
@jimchamp jimchamp added Affects: UI Issues with the web site's user interface. [managed] Priority: 2 Important, as time permits. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Nov 24, 2020
@LeadSongDog
Copy link

Seemingly the upper Delete button is nonfunctional, at least on mobile.

@mekarpeles mekarpeles added Good First Issue Easy issue. Good for newcomers. [managed] help-wanted Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Dec 8, 2020
@mekarpeles mekarpeles added this to the Active Sprint milestone Dec 8, 2020
@cdrini cdrini removed their assignment Dec 14, 2020
@mekarpeles mekarpeles removed the Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] label Oct 24, 2021
@LeadSongDog LeadSongDog mentioned this issue Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2020-12
Development

Successfully merging a pull request may close this issue.

Remove the Duplicate Delete Button on Edit Authors Page nk4456542/openlibrary
5 participants
@mekarpeles @cdrini @LeadSongDog @seabelis @jimchamp