Remove the Duplicate Delete Button on Edit Authors Page #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to test this change locally, and it worked as expected. The redundant dangerously positioned delete button was removed, and the other delete button functioned properly. |
|
Tested this locally, seems to be working fine. I have attached the After:
@seabelis, can you please comment if it is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4101
Removes the duplicate delete button present in the edit authors page.
Technical
Removed the delete button present in the
openlibrary/templates/type/author/edit.html.Testing
I was not able to test this as the local setup is down, details in this issue #4090
Screenshot
Stakeholders
@seabelis