Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to solve recaptcha on 'add/edit a book' results in data entry loss #433

Closed
skylerbunny opened this issue Mar 5, 2017 · 5 comments

Comments

@skylerbunny
Copy link
Contributor

If a contributor is adding information about a book and do not get the recaptcha correct, information that may have been entered will be lost upon either clicking the browser back button or using the 'Go Back' link provided:

  • Contributors that have been added in that session will disappear, except for the author
  • Identifiers (ISBN10, etc.) that have been added in that session will disappear

This means that there is a 'cost' to getting the recaptcha wrong beyond simply having to solve the recaptcha again; a contributor will be forced to re-enter information.

@mekarpeles
Copy link
Member

This sucks, we should fix this. Thanks for reporting

@hornc
Copy link
Collaborator

hornc commented Jul 1, 2017

It seems the only values that are retained on using browser back are retained by the browser cache. Authors and Identifiers are added to the page by other actions (Author autocomplete, and the Identifier 'Add' button) and therefore aren't retained in the same way the normal form field values are, so they are lost.

There a probably multiple ways to do this better

  • AJAX verification of recaptcha before leaving the page?
  • ability to re-load the form using the values that were previously POSTed

I think though that updating the recaptcha to the currently supported version is the sensible first step. Not sure of the priorities here.

@hornc hornc added the recaptcha label Jul 1, 2017
@sbshah97
Copy link
Contributor

@mekarpeles @hornc will #809 have any conflicts with this one? I'm not so sure!

@sbshah97
Copy link
Contributor

sbshah97 commented Mar 8, 2018

@mekarpeles ?

@mekarpeles
Copy link
Member

I believe I tested this and its working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants