Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make POT creation date static in messages.pot #9208

Closed
rebecca-shoptaw opened this issue May 2, 2024 · 0 comments · Fixed by #9210
Closed

Make POT creation date static in messages.pot #9208

rebecca-shoptaw opened this issue May 2, 2024 · 0 comments · Fixed by #9210
Assignees
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Type: Bug Something isn't working. [managed]

Comments

@rebecca-shoptaw
Copy link
Collaborator

rebecca-shoptaw commented May 2, 2024

Describe the problem that you'd like solved

Now that we've merged in the messages.pot auto-extraction process (#8900), we want to make sure to avoid any contributors who find themselves with auto-added messages.pot updates from having to deal with any merge conflicts as result.

Conflicts with messages.pot will be inevitable if contributors are changing or removing existing text from the site, but they should not occur if contributors are merely adding new text to the site. This is currently happening because of the POT-Creation-Date field which updates when any changes are made.

Proposal & Constraints

While we cannot remove the creation date from the template, we can set it to a fixed date. Demo implementation from the Babel docs below:

from babel.dates import UTC
from datetime import datetime
created = datetime(1990, 4, 1, 15, 30, tzinfo=UTC)
catalog = Catalog(project='Foobar', version='1.0',
                  creation_date=created)

I propose we set the date to be fixed at the last time a new master messages.pot was manually generated, which will be 05/01/24 for now. We can add a comment to the generating function to explain how this date was selected and when to update it.

Additional context

Stakeholders

@cdrini

@rebecca-shoptaw rebecca-shoptaw added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 2, 2024
@rebecca-shoptaw rebecca-shoptaw self-assigned this May 2, 2024
@rebecca-shoptaw rebecca-shoptaw added Type: Bug Something isn't working. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] and removed Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant