Dead code elimination and documentation #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the bundles are slightly too big and CI is failing.
There's no need for these 2 files. Let's merge them. Going forward, we also want to split up/clean these files and remove it, so we rename it legacy.less to provide this signal to other people working with this codebase Additional change: * Delete unused script file (static/css/all.cssh) - looks like this used to be used for concatenation but it is not longer needed.
To avoid confusion, from now on all entry points in the static/css folder will either be prefixed with `page-` or `js-` Documentation is added to explain the layout of this folder going forward Additional changes: * The newly named page-design stylesheet is expanded to include the rules inside legacy.less and is added to the page consistently with other pages * page-dev continues to be loaded as before - in conjunction with whatever the stylesheet for that page is * Books-edit makes use of $static_url to generate its url * For consistency with other pages, the book widget page now has an id on its body tag which reflects the name of its css file.
While this file may be useful for development (am not convinced), lets not encourage the addition of CSS here inside our repo. We may alternatively decide to remove this file.
On closer inspection these are not needed on the home page and possibly unnecessary. The "on" class only seems to appear when used with links inside a ".tools" element and then only when JavaScript is enabled. Since it's only added with JavaScript ( inside openlibrary/plugins/openlibrary/js/ol.js) move to js-all entry point.
Certain styles for the borrowTable component only apply to the component in certain page categories (admin, plain, user) Instead of loading them on every page, we load them where needed on the presumption we'll clean this up later.
No need to load them on all pages. Also given these styles don't make sense on mobile, stick them in the desktop media query.
Not referenced anywhere so let's delete.
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and document the current state of the styles folder.
Please read individual commit messages.