Non-MARC import from archive.org #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hornc
force-pushed
the
feature/no-marc-import
branch
from
1a66272
to
28dac2e
Compare
hornc
force-pushed
the
feature/no-marc-import
branch
from
28dac2e
to
f8063f0
Compare
mekarpeles
reviewed
Mar 12, 2019
| @@ -1,6 +1,5 @@ | |||
| """Library for interacting wih archive.org. | |||
| """ | |||
| from __future__ import print_function | |||
There was a problem hiding this comment.
why was this removed? Because the print functions were removed? (this was for python 3 compat.)
There was a problem hiding this comment.
There are no uses of print in the module.
mekarpeles
reviewed
Mar 12, 2019
| if subject: | ||
| d["subjects"] = isinstance(subject, list) and subject or [subject] |
There was a problem hiding this comment.
did we not need this checking logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the metadata importing from Archive.org items that do no have MARC records.
The following item, https://openlibrary.org/books/OL26746219M , was imported using the https://github.com/internetarchive/openlibrary/wiki/Endpoints#importing
POST /api/import/iaendoint"require_marc": "false"option, and had some issues / missing metadata. This PR fixes those./languages/porinstead ofporTagging @tfmorris who noticed these issues too.
Requires #1979 (for local testing), wait until that PR is merged before merging this one.