Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no cover show title and author #2729

Merged
merged 4 commits into from
Dec 13, 2019
Merged

When no cover show title and author #2729

merged 4 commits into from
Dec 13, 2019

Commits on Dec 13, 2019

  1. When no cover show title and description 

    This borrows code from openlibrary/templates/covers/book_cover.html
but rather than wrestle with legacy code makes use of a single class name
and leaner CSS.

Fixes: internetarchive#2247
    @jdlrobson @cdrini
    jdlrobson authored and cdrini committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    223090a View commit details
    Browse the repository at this point in the history

  2. tweaks to blank cover code/style

    @cdrini
    cdrini committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    38b4af7 View commit details
    Browse the repository at this point in the history

  3. Make sure author_names variable is always defined

    @jdlrobson
    jdlrobson committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    5ad1646 View commit details
    Browse the repository at this point in the history

  4. author_names is string not boolean 

    this matches the way it is used in the template
    @jdlrobson
    jdlrobson committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    caff690 View commit details
    Browse the repository at this point in the history