Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3720/bug/manage solr logs #4066

Merged
merged 5 commits into from Nov 20, 2020

Conversation

jimchamp
Copy link
Collaborator

Closes #3720

Creates daily cron job in olsolr that removes all files in /var/log/tomcat7/ that are more than seven days old. Also sets limits on the size of Docker's olsolr logs.

Technical

Testing

Screenshot

Stakeholders

-  Job deletes all files in /var/log/tomcat7 that are over 7 days old
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a super elegant & simple solution! I like it :) A few small comments

conf/solr/rmlog Outdated Show resolved Hide resolved
docker/Dockerfile.olsolr Outdated Show resolved Hide resolved
@cdrini cdrini added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Nov 20, 2020
@jimchamp jimchamp requested a review from cdrini November 20, 2020 02:37
@cdrini cdrini added Needs: Special Deploy This PR will need a non-standard deploy to production and removed Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels Nov 20, 2020
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I tested running the command inside the solr container manually, and it wasn't matching any files, but a bit of positive thinking seemed to fix that :) Haven't tested the full flow (i.e. cron is successfully running, etc); we're making loads of changes to the docker-compose file right now because of the py3 stuff, so would rather we get this merged in now :) I'll deploy to ol-solr1 and check tomorrow to see if it was deleted!

conf/solr/rmlog.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate solr service + tomcat7 logs
2 participants