GitHub Action to test Python code #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Travis CI no longer freely supports open source projects.
cclauss
force-pushed
the
GitHub-Action-lint_python.yml
branch
from
8fa99dc
to
f0174cc
Compare
cclauss
changed the title
cclauss
added
Needs: Testing
Theme: Testing
|
|
cdrini
requested changes
Dec 11, 2020
There was a problem hiding this comment.
Lgtm! Only blocker is ubuntu version should match our dockerfile, and a suggestion to make the step names a little cleaner.
EDIT: Oh! I forgot; remove the python checks from Travis! We don't need them anymore :)
EDIT: Ooops, something went wrong; sorry for the duplicate comments!
|
Oh! I forgot; main block is remove or comment out from the travis file whatever is being run here; don't need them to be running twice 👍 (Edited CR) |
Co-authored-by: Drini Cami <cdrini@gmail.com>
cdrini
requested changes
Dec 11, 2020
Co-authored-by: Drini Cami <cdrini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4207
Because Travis CI no longer freely supports open-source projects.
Closes #
Technical
Testing
Screenshot
Stakeholders