Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Nothing type when exporting lists #6081

Conversation

jimchamp
Copy link
Collaborator

Closes #5415

Uses JSON encoder with Nothing serializer for list exports.

Technical

Call to standard json.dumps in formats.dump has been replaced with helpers.json_encode call.

format.dump appears to only be used in lists.py to return data related to lists.

Testing

Screenshot

Stakeholders

@jimchamp
Copy link
Collaborator Author

Totally incorrect approach. helpers.json_encode does not handle Nothing values --- it returns an empty list if the input is a Nothing object instead of a dict.

@jimchamp jimchamp closed this Jan 27, 2022
@jimchamp jimchamp deleted the 5415/bug/encode-Nothing-types branch January 27, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Nothing type not JSON serializable" errors occurring when fetching list data from /seeds.json
1 participant