Create custom JSON encoder for Nothing values #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
added
the
On testing.openlibrary.org
|
These changes LGTM, tested on testing |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5415
Creates custom JSON encoder which converts
Nothingobjects intoNone. Adds encoder tohelpers.dump.Technical
format.dumpappears to only be used in lists.py to return data related to lists.Testing
This code is on testing now. Compare the following list data in production and testing:
http://openlibrary.org/people/tmanarl/lists/OL197952L/seeds.json?debug=true
http://testing.openlibrary.org/people/tmanarl/lists/OL197952L/seeds.json?debug=true
The production link errors out, while the
Nothingvalues have been replaced withnullin the JSON string returned in testing.Screenshot
Stakeholders