Added synonyms to solr #6922
Open
Added synonyms to solr #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfmorris
suggested changes
Aug 31, 2022
There was a problem hiding this comment.
Roman numerals and random Ukrainian abbreviations seems like an odd set of stuff to focus on as the highest priority.
Many of the Roman numerals, as well the English names, are incorrect. I've provided a few examples, but the whole thing needs review/revision.
Co-authored-by: Tom Morris <tfmorris@gmail.com>
|
Sorry for the delay on this folks, testing this is a little complicated so will require me having a chunk of time to dig into it ! |
cdrini
reviewed
Jan 16, 2024
| Television, Televisions, TV, TVs | ||
| Volume, Vol., Vol | ||
| &, and | ||
| 1, One, I |
There was a problem hiding this comment.
We should test this one; this might cause false positives. Adding Vol. 1, Vol. I might be a more robust approach? But needs some testing. If Conail has some time, he should be able to load this up to run it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6635
Technical
Testing
To test locally:
To test on staging solr (staff only):
TODO
Screenshot
Stakeholders
@cdrini @popcar2