Tag type creation and crud functions #7928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaydenTeoh
force-pushed
the
feature/tags-crud
branch
from
4b62ff6
to
c94708b
Compare
mekarpeles
reviewed
Jun 7, 2023
for more information, see https://pre-commit.ci
|
I would be great if the DDL was included with this PR. It could be added to https://github.com/internetarchive/openlibrary/blob/master/openlibrary/core/infobase_schema.sql, which contains DDL for many other Infogami types. |
|
@jimchamp Hi Jim, I've added the DDL for tags as requested, would you mind taking a look to verify that I have not missed anything out? Thank you! |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@mekarpeles Made a small change to remove duplicate Tag class registration as an Infogami 'Thing' within the recent commit. Let's test the staging of this PR again just to be sure it does not affect anything. |
mekarpeles
reviewed
Jul 3, 2023
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR containing only Tag type creation and its basic crud functions. This allows us divide the original Tags PR #7766 into segments to be added into production for easier testing.
Stakeholders
@mekarpeles