Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make covers.py compatible with web.py cgi.FieldStorage removal #8313

Merged

Conversation

scottbarnes
Copy link
Collaborator

@scottbarnes scottbarnes commented Sep 20, 2023

Closes #8147

NOTE: This is blocked pending an update to web.py. We have a few proposed solutions for that. Here's one: webpy/webpy#773.

Fix.

This changes covers.py to reflect the changed field names brought on by web.py's switch to multipart.

Deploy Notes

This will affect every request made on the website + cover uploads. We'll want to monitor after deploying (and also try on staging)

Technical

Some field names changed, as the diff will show.

Additionally, the web.py version in requirements.txt has been pinned to the commit with the cgi.FieldStorage change: webpy/webpy@ed3e92c.

Testing

  • Add a cover;
  • Delete a cover; and
  • Generally use the site every page load goes through the changes to web.py, and although all the tests pass here, it's possible there's some changed functionality somewhere.

Stakeholders

@mekarpeles
@tfmorris

@scottbarnes scottbarnes marked this pull request as draft September 20, 2023 02:48
@scottbarnes scottbarnes marked this pull request as ready for review September 25, 2023 18:08
@scottbarnes scottbarnes added the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Sep 25, 2023
@mekarpeles mekarpeles self-assigned this Sep 25, 2023
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Sep 25, 2023
@scottbarnes
Copy link
Collaborator Author

Note: This will need to update requirements.txt because this current PR will break things if used with the prior version of web.py.

@scottbarnes scottbarnes added State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] and removed State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] labels Oct 16, 2023
@scottbarnes scottbarnes marked this pull request as draft October 16, 2023 17:52
@scottbarnes
Copy link
Collaborator Author

I am investigating a problem with this PR and webpy v0.70.

@tfmorris
Copy link
Contributor

It looks like there's a discrepancy between file here and filename in https://github.com/webpy/webpy/blob/master/web/webapi.py#L456

The FIXME there should probably be addressed/removed, as well.

@tfmorris
Copy link
Contributor

@scottbarnes Is this still needed or is the new webpy update a drop-in replacement now?

@scottbarnes
Copy link
Collaborator Author

@scottbarnes Is this still needed or is the new webpy update a drop-in replacement now?

Alas, it is still needed.

@scottbarnes scottbarnes marked this pull request as ready for review November 30, 2023 07:16
@scottbarnes scottbarnes added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Nov 30, 2023
@mekarpeles mekarpeles added State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels Nov 30, 2023
@scottbarnes
Copy link
Collaborator Author

@mekarpeles, I'm sorry for being a bit slow, but what sort of input are you looking for?

@mekarpeles mekarpeles added the Needs: Special Deploy This PR will need a non-standard deploy to production label Dec 4, 2023
@mekarpeles mekarpeles merged commit 2eace4f into internetarchive:master Dec 4, 2023
3 checks passed
@scottbarnes scottbarnes deleted the webpy-cgi-fieldstorage-changes branch December 7, 2023 22:53
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cgi.FieldStorage to unblock Python 3.13
4 participants