get_marc_record_from_ia: use existing metadata if present #8332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
the
Priority: 1
cdrini
approved these changes
Oct 19, 2023
cdrini
added
the
Needs: Submitter Input
|
Note I didn't test ; this seems pretty safe. (famous last words 😁 ) |
cdrini
reviewed
Oct 19, 2023
cdrini
added
the
On testing.openlibrary.org
scottbarnes
force-pushed
the
fix/ia_import_twice_queries_ia_metadata_api
branch
from
c637964
to
b8456b3
Compare
scottbarnes
removed
the
Needs: Submitter Input
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix.
Technical
Currently
ia_import()will twice query the (memcached) Internet Archive API during the process for importing from an Internet Archive ID.This PR passes the already-fetched
metadatato the function that calls the metadata API again (get_marc_record_from_ia()), thereby avoiding the second call to the (memcached) API.First, in "case 1", the metadata is gathered:
Once #8331 is merged, this will be the final query to the the IA metadata API, if that IA record has data in the
openlibrary_editionfield. ("Case 2".)However, if the IA record does not have data in
openlibrary_edition, then there is a query for MARC data from the IA item, which callsget_marc_record_from_ia(), which again calls the metadata API:This PR avoids that second query.
Testing
Verify already-fetch metadata is now passed into
get_marc_record_from_ia(), and that IA imports still work as expected.Stakeholders
@cdrini