Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #8323 title work break #8340

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

davidscotson
Copy link
Collaborator

@davidscotson davidscotson commented Sep 27, 2023

Closes #8323

Adds word break in two places, work and edition title (and same again in mobile view)when a word in the title exceeds the space available.

Screenshot

Screenshot 2023-09-27 at 11 35 24 Screenshot 2023-09-27 at 11 36 11 Screenshot 2023-09-27 at 11 36 24

Stakeholders

@mekarpeles mekarpeles self-assigned this Oct 2, 2023
@mekarpeles mekarpeles added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Oct 2, 2023
@RayBB RayBB added this to Waiting Review/Merge from Staff in Ray's Project Oct 6, 2023
@cdrini
Copy link
Collaborator

cdrini commented Oct 26, 2023

I'll take this one over since it's very close to the finish line 👍

@cdrini cdrini assigned davidscotson and cdrini and unassigned mekarpeles and davidscotson Oct 26, 2023
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on testing works like a charm! Thanks @davidscotson !

@cdrini cdrini merged commit 38162c8 into internetarchive:master Oct 26, 2023
3 checks passed
Ray's Project automation moved this from Waiting Review/Merge from Staff to Done Oct 26, 2023
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Book/work page breaks when title is very long
4 participants